Change DataInKeySpacePath to contain a KeySpacePath instead of ResolvedKeySpacePath #3716
+98
−429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edKeySpacePath It was unnecessary to have the ResolvedKeySpacePath, and we want to be able to import into a different cluster, where the resolved values are different from the exported data. This means that DataInKeySpacePath has a few more fields, but makes it more versatile going forward.
ScottDugas
commented
Nov 3, 2025
|
|
||
| public CompletableFuture<ResolvedKeySpacePath> getResolvedPath() { | ||
| return resolvedPath; | ||
| this.value = value; |
Collaborator
Author
There was a problem hiding this comment.
Instead of copying the byte[] here and in getValue, I created an issue to convert it to ByteString: #3717
ohadzeliger
requested changes
Nov 6, 2025
| * @return a future that completes with the resolved path including the remainder | ||
| */ | ||
| @Nonnull | ||
| public CompletableFuture<ResolvedKeySpacePath> getResolvedPath(@Nonnull FDBRecordContext context) { |
Contributor
There was a problem hiding this comment.
Where is this going to be used? Is this intended for future (import)?
Collaborator
Author
There was a problem hiding this comment.
I think this was added to make the tests keep working, but the tests have been updated since then, and so it makes sense to remove the last usage.
| */ | ||
| @Nonnull | ||
| public CompletableFuture<ResolvedKeySpacePath> getResolvedPath(@Nonnull FDBRecordContext context) { | ||
| return path.toResolvedPathAsync(context) |
Contributor
There was a problem hiding this comment.
path.toResolvedPathAsync can be removed from the interface (only called internally)?
| * @return a new {@code ResolvedKeySpacePath} that is the same as this, except with a different {@link #getRemainder()}. | ||
| */ | ||
| @Nonnull | ||
| @VisibleForTesting |
Contributor
There was a problem hiding this comment.
if getResolvedPath is removed from DataInKeyspacePath, then maybe this method can be removed as well (or stay as VisibleForTesting?)
This is only needed by KeySpacePathImpl.exportAllData, so lets not pollute the interface until needed. I kept the tests around because I think that gives some extra coverage in a nicer way than having it all on exportAllData.
No production code is using it anymore. We could inline it, but I feel like keeping the constructor private is more valuable.
Conflicted on KeySpacePath
ohadzeliger
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unnecessary to have the ResolvedKeySpacePath, and we want to be able to import into a different cluster, where the resolved values are different from the exported data.
This means that DataInKeySpacePath has a few more fields, but makes it more versatile going forward.
This also changes
exportAllDatato usemapPipelinedto resolve the path, so thatDataInKeySpacePathdoes not contain a future.This is in support of #3573